[pigeon] Deprecate dartHostTestHandler #10403
Conversation
Deprecates `dartHostTestHandler`, in preparation for removing sometime in 2026 if no significant new information comes to light. Part of flutter/flutter#178322
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: deprecating existing code |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively deprecates dartHostTestHandler and its associated option dartTestOut. The changes are consistent across the codebase, including updates to the API, options, version, and changelog.
To make the deprecation more complete, you might also consider deprecating the dart_test_out command-line option in _argParser (in packages/pigeon/lib/src/pigeon_lib.dart) by marking it as hidden (hide: true) and updating its help text. This would make the command-line interface consistent with the API deprecation.
I have one minor suggestion to make the changelog entry more explicit.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
tarrinneal
added
the
autosubmit
flutter/packages@7063d75...e5ecaf7 2025-11-12 [email protected] [google_sign_in_android] Fix typos in README.md (flutter/packages#10402) 2025-11-12 [email protected] [image_picker] Fixes README description of plugin suggesting that only Android and iOS is supported. (flutter/packages#10385) 2025-11-12 [email protected] [pigeon] Deprecate dartHostTestHandler (flutter/packages#10403) 2025-11-11 [email protected] Bumping CI to Test Against JDK 21 (flutter/packages#10193) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Deprecates
dartHostTestHandler, in preparation for removing sometime in 2026 if no significant new information comes to light.Part of flutter/flutter#178322
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3